<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - [HD Graphics 4000] Segfault accessing rq->bo->handle" href="https://bugs.freedesktop.org/show_bug.cgi?id=91577#c13">Comment # 13</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - [HD Graphics 4000] Segfault accessing rq->bo->handle" href="https://bugs.freedesktop.org/show_bug.cgi?id=91577">bug 91577</a> from <a class="email" href="mailto:chris@chris-wilson.co.uk" title="Chris Wilson <chris@chris-wilson.co.uk>"> Chris Wilson</a> <pre>Cursor doesn't do anything for me with links in the terminal. Do you mind sending me the complete debug log, I want to see how we end up 64k buffers? In the meantime, commit 69d8edc11173df021aa2e158b2530257113141fd Author: Chris Wilson <<a href="mailto:chris@chris-wilson.co.uk">chris@chris-wilson.co.uk</a>> Date: Fri Aug 7 10:08:17 2015 +0100 sna: Handle batch allocation failure Whilst we currently do not try and submit a failed batch buffer allocation, we still treat it as a valid request. This explodes much later when we inspect the NULL rq->bo. References: <a class="bz_bug_link bz_status_NEW " title="NEW - [HD Graphics 4000] Segfault accessing rq->bo->handle" href="show_bug.cgi?id=91577">https://bugs.freedesktop.org/show_bug.cgi?id=91577</a> Signed-off-by: Chris Wilson <<a href="mailto:chris@chris-wilson.co.uk">chris@chris-wilson.co.uk</a>> commit 8c465d0fbf84b1d29c54d620f09063d2b7ccfeb8 Author: Chris Wilson <<a href="mailto:chris@chris-wilson.co.uk">chris@chris-wilson.co.uk</a>> Date: Fri Aug 7 10:15:42 2015 +0100 sna: Fallback after a bo allocation failure for the batch If we fail to allocate the next bo to use for the next_request, we can just fallback to the delayed allocation used by !llc. Bugzilla: <a class="bz_bug_link bz_status_NEW " title="NEW - [HD Graphics 4000] Segfault accessing rq->bo->handle" href="show_bug.cgi?id=91577">https://bugs.freedesktop.org/show_bug.cgi?id=91577</a> Signed-off-by: Chris Wilson <<a href="mailto:chris@chris-wilson.co.uk">chris@chris-wilson.co.uk</a>> commit ca71199679cac9cc161c84cb09d12f133abf8a64 Author: Chris Wilson <<a href="mailto:chris@chris-wilson.co.uk">chris@chris-wilson.co.uk</a>> Date: Fri Aug 7 10:40:30 2015 +0100 sna: Harden batch allocation against resource starvation If the batch allocation fails, retire the oldest request and try again. References: <a class="bz_bug_link bz_status_NEW " title="NEW - [HD Graphics 4000] Segfault accessing rq->bo->handle" href="show_bug.cgi?id=91577">https://bugs.freedesktop.org/show_bug.cgi?id=91577</a> Signed-off-by: Chris Wilson <<a href="mailto:chris@chris-wilson.co.uk">chris@chris-wilson.co.uk</a>> should prevent the allocation failure, or if we can't prevent it, handle it correctly.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the QA Contact for the bug.</li> </ul> </body> </html>