<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_ASSIGNED " title="ASSIGNED - [SKL, BIOS upgrade regression] distorted display after resume from suspend" href="https://bugs.freedesktop.org/show_bug.cgi?id=91697#c16">Comment # 16</a> on <a class="bz_bug_link bz_status_ASSIGNED " title="ASSIGNED - [SKL, BIOS upgrade regression] distorted display after resume from suspend" href="https://bugs.freedesktop.org/show_bug.cgi?id=91697">bug 91697</a> from <a class="email" href="mailto:damien.lespiau@gmail.com" title="Damien Lespiau <damien.lespiau@gmail.com>"> Damien Lespiau</a> <pre>As an early review: Your patch makes the code still go through skl_dpll0_enable() when PLL0 is on after resume, which touches the CDCLK and DPLL0 registers. It sort of work because the PLL is already locked and the writes ignored but doesn't feel totally satisfactory. Could you skip skl_dpll0_enable() if DPLL0 is already enabled? Thanks,</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the QA Contact for the bug.</li> <li>You are on the CC list for the bug.</li> <li>You are the assignee for the bug.</li> </ul> </body> </html>