<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Segmentation Fault in sna_put_zpixmap_blt (X server crash)"
href="https://bugs.freedesktop.org/show_bug.cgi?id=92751#c23">Comment # 23</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Segmentation Fault in sna_put_zpixmap_blt (X server crash)"
href="https://bugs.freedesktop.org/show_bug.cgi?id=92751">bug 92751</a>
from <span class="vcard"><a class="email" href="mailto:chris@chris-wilson.co.uk" title="Chris Wilson <chris@chris-wilson.co.uk>"> <span class="fn">Chris Wilson</span></a>
</span></b>
<pre>Still haven't found the possible list/element corruption, but could you try
this simplification:
diff --git a/src/sna/kgem.c b/src/sna/kgem.c
index b80fde7..0f1c1f4 100644
--- a/src/sna/kgem.c
+++ b/src/sna/kgem.c
@@ -3275,12 +3275,11 @@ bool __kgem_ring_is_idle(struct kgem *kgem, int ring)
bool __kgem_retire_requests_upto(struct kgem *kgem, struct kgem_bo *bo)
{
- struct kgem_request *rq = bo->rq, *tmp;
- struct list *requests = &kgem->requests[RQ_RING(rq) == KGEM_BLT];
+ struct kgem_request *rq = RQ(bo->rq), *tmp;
+ struct list *requests = &kgem->requests[rq->ring];
- DBG(("%s(handle=%d)\n", __FUNCTION__, bo->handle));
+ DBG(("%s(handle=%d, ring=%d)\n", __FUNCTION__, bo->handle, rq->ring));
- rq = RQ(rq);
assert(rq != &kgem->static_request);
if (rq == (struct kgem_request *)kgem) {
__kgem_bo_clear_busy(bo);</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
</ul>
</body>
</html>