[Intel-gfx] [PATCH] Rework DRM proc file handling
dbn.lists at gmail.com
Wed Dec 10 15:22:39 CET 2008
On Tue, Dec 9, 2008 at 5:27 PM, Ben Gamari <bgamari at gmail.com> wrote:
> On Tue, 2008-12-09 at 11:19 -0800, Dan Nicholson wrote:
>> I just had a quick scan of the patch, but a couple things jumped out.
>> - The debugfs code should be conditional on CONFIG_DEBUG_FS.
>> - // C++ comments
>> - Some of the lowlevel *__*_info functions now only return 0. Could
>> these be converted to void instead?
> Here's a new patch to correct those few items. I'm not exactly sure if I
> conditional-ized the debugfs code correctly. I also added a Kconfig item
> for the debugfs interface.
I was thinking more that if you had CONFIG_DEBUG_FS, you should just
get the code, rather than adding a new Kconfig item. But it doesn't
look like many of the other drivers actually bother with that, so
maybe it's all overkill.
More information about the Intel-gfx