[Intel-gfx] uxa_prepare_access can fail

Eric Anholt eric at anholt.net
Mon Dec 15 01:31:42 CET 2008


On Sat, 2008-12-13 at 14:54 -0800, Keith Packard wrote:
> Running UXA overnight, I had the kernel fail to map a new pixmap (that's
> a separate issue, of course). However, nothing up the call stack checks
> this failure, and so the X server happily attempts to dereference NULL.
> 
> I've patched libdrm/intel (to actually return the kernel error) and then
> patched uxa to check for the error.

Ack to these two.

Also, uxa_do_put_image has some serious bogusness in it if you fail to
accelerate one of the uploads but not later ones -- you won't
re-prepareaccess.

-- 
Eric Anholt
eric at anholt.net                         eric.anholt at intel.com


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20081214/8d991892/attachment.sig>


More information about the Intel-gfx mailing list