[Intel-gfx] xf86-video-intel: src/xvmc/intel_xvmc.c

Zhenyu Wang zhenyu.z.wang at intel.com
Thu Dec 18 09:06:43 CET 2008


On 2008.12.17 13:55:41 +0800, Nan hai Zou wrote:
> 
>  src/xvmc/intel_xvmc.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> New commits:
> commit 555eea5411cf8c725df5f1b4cb80198fa6a1225b
> Author: Zou Nan hai <nanhai.zou at intel.com>
> Date:   Wed Dec 17 13:55:07 2008 +0800
> 
>      wait vblank before render to fix tearing
> 
> diff --git a/src/xvmc/intel_xvmc.c b/src/xvmc/intel_xvmc.c
> index dbde22f..c197e35 100644
> --- a/src/xvmc/intel_xvmc.c
> +++ b/src/xvmc/intel_xvmc.c
> @@ -757,7 +757,7 @@ _X_EXPORT Status XvMCPutSurface(Display *display,XvMCSurface *surface,
>      }
>      intel_surf->last_draw = draw;
>      /* fill intel_surf->data */
> -    if (0)
> +    if (1)
>      {
>  	drmVBlank vbl;
>  	vbl.request.type = DRM_VBLANK_RELATIVE;

This is broken as no care is taken for vblank pipes (e.g I have to 
add DRM_VBLANK_SECONDARY for my GM965 LVDS on pipe B).
As XvMC uses Xv port for video playback, we should just fix
Xv port for vblank sync. My suggest is to add a Xv port attribute
for texture video, that can flip vblank wait on or off. Or we
might steal some idea from radeon driver. But doing this in XvMC
lib is wrong to me anyway.

Please send non-trivial patches to intel-gfx at lists.freedesktop.org 
before you pushing for review. Thanks.

-- 
Open Source Technology Center, Intel ltd.

$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20081218/46ca45b5/attachment.pgp>


More information about the Intel-gfx mailing list