[Intel-gfx] [PATCH] [drm/i915] Don't run retire work handler while suspended
eric at anholt.net
Tue Oct 14 21:57:43 PDT 2008
On Tue, 2008-10-14 at 21:41 -0700, Keith Packard wrote:
> On Tue, 2008-10-14 at 21:08 -0700, Eric Anholt wrote:
> > I think the solution here is setting the suspended semaphore before
> > canceling the work, to kill further execbufs. I suspect that with that,
> > the additional cancel_work semaphore isn't needed.
> Yup. Also, we need to prevent work queued during the shutdown from
> starting the retire work handler again. Here's a patch which does all of
> that. Sorry for restructuring i915_gem_idle, but the alternative was
> fairly ugly.
Ahh, I thought you were talking about the work handler requeueing
itself, but you meant later operations in gem_idle. Yeah.
> From bb5b95dc54cf09571d41fb53dc1d612b826dd217 Mon Sep 17 00:00:00 2001
> From: Keith Packard <keithp at keithp.com>
> Date: Tue, 14 Oct 2008 20:48:42 -0700
> Subject: [PATCH] [drm/i915] Don't run retire work handler while suspended
> At leavevt and lastclose time, cancel any pending retire work handler
> invocation, and keep the retire work handler from requeuing itself if it is
> currently running.
> This patch restructures i915_gem_idle to perform all of these tasks instead
> of having both leavevt and lastclose call a sequence of functions.
Looks good, and working great on my GM45. Pushed.
eric at anholt.net eric.anholt at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 197 bytes
Desc: This is a digitally signed message part
Url : http://lists.freedesktop.org/archives/intel-gfx/attachments/20081014/cd9e7f35/attachment.pgp
More information about the Intel-gfx