[Intel-gfx] [PATCH] [drm/i915] Disable MSI on GM965 (errata says it doesn't work)
eric at anholt.net
Fri Oct 17 00:55:35 PDT 2008
On Fri, 2008-10-17 at 00:44 -0700, Keith Packard wrote:
> Current Intel errata for the GM965 says that using MSI may cause interrupts
> to be delayed or lost. The only workaround offered is to not use it.
> Signed-off-by: Keith Packard <keithp at keithp.com>
> drivers/gpu/drm/i915/i915_dma.c | 5 ++++-
> 1 files changed, 4 insertions(+), 1 deletions(-)
> diff --git a/drivers/gpu/drm/i915/i915_dma.c b/drivers/gpu/drm/i915/i915_dma.c
> index 593286e..d77e366 100644
> --- a/drivers/gpu/drm/i915/i915_dma.c
> +++ b/drivers/gpu/drm/i915/i915_dma.c
> @@ -844,8 +844,11 @@ int i915_driver_load(struct drm_device *dev, unsigned long flags)
> * correctly in testing on 945G.
> * This may be a side effect of MSI having been made available for PEG
> * and the registers being closely associated.
> + *
> + * According to chipset errata, on the 965GM, MSI interrupts may
> + * be lost or delayed
> - if (!IS_I945G(dev) && !IS_I945GM(dev))
> + if (!IS_I945G(dev) && !IS_I945GM(dev) && !IS_I965GM(dev))
> if (pci_enable_msi(dev->pdev))
> DRM_ERROR("failed to enable MSI\n");
Pushed. For those curious, see errata number 5 at:
eric at anholt.net eric.anholt at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 197 bytes
Desc: This is a digitally signed message part
Url : http://lists.freedesktop.org/archives/intel-gfx/attachments/20081017/0e72c6ba/attachment-0001.pgp
More information about the Intel-gfx