[Intel-gfx] Align the height of untiled pixmaps to 2 lines as well

Eric Anholt eric at anholt.net
Wed Aug 19 18:27:46 CEST 2009


On Wed, 2009-08-19 at 09:27 -0700, Carl Worth wrote:
> Excerpts from anholt's message of Wed Aug 19 09:21:11 -0700 2009:
> >     Align the height of untiled pixmaps to 2 lines as well.
> >     
> >     The 965 docs note, and it's probably the case on 915 as well, that the
> >     2x2 subspans are read as a unit, even if the bottom row isn't used.  If
> >     the address in that bottom row extended beyond the end of the GTT, a
> >     fault could occur.
> >     
> >     Thanks to Chris Wilson for pointing out the problem.
> 
> This sounds like sometehing that could fix some "random crashes" bugs, right?
> 
> Shall we cherry-pick this to the 2.8 branch for the 2.8.1 release?

It's already on the wiki, it just didn't have a sha1 :)

-- 
Eric Anholt
eric at anholt.net                         eric.anholt at intel.com


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20090819/840cdf27/attachment.sig>


More information about the Intel-gfx mailing list