[Intel-gfx] [PATCH] drm/i915: add the missing clone mask for display port on IGDNG

ykzhao yakui.zhao at intel.com
Wed Dec 2 01:53:27 CET 2009


On Wed, 2009-12-02 at 01:58 +0800, Eric Anholt wrote:
> On Tue,  1 Dec 2009 15:12:28 +0800, yakui.zhao at intel.com wrote:
> > From: Zhao Yakui <yakui.zhao at intel.com>
> > 
> > Add the missing clone mask for display port on IGDNG.
> > 
> > At the same time it also fix the error condition judgement in the function of
> > dp_is_present_in_vbt.
> > 
> > Signed-off-by: Zhao Yakui <yakui.zhao at intel.com>
> > Reviewd-by: Zhenyu Wang <zhenyuw at linux.intel.com>
> 
> This pretty clearly seems to be two different patches stuck together:
> Fix the breakage in dp_is_present_in_vbt, and fix an Ironlake-specific
> problem not related to VBT parsing.  Could you send it as two patches?
You are right. 
The two issues are stuck together. I will split them into two different
patches.
> 
> Also, we can call it Ironlake instaed of IGDNG, even if we aren't doing
> so in the code yet.
> 
> jcristau mentioned another issue in the VBT parsing: all those new
> functions weren't marked static.  That should get fixed.
Ok. I will fix them.

Thanks.





More information about the Intel-gfx mailing list