[Intel-gfx] [PATCH 2/2] drm/i915: Search again if we cannot find enough space in the aperture

Eric Anholt eric at anholt.net
Tue Dec 8 00:45:56 CET 2009


On Wed, 02 Dec 2009 15:30:29 +0000, Chris Wilson <chris at chris-wilson.co.uk> wrote:
> On Wed,  2 Dec 2009 15:15:31 +0000, Chris Wilson <chris at chris-wilson.co.uk> wrote:
> > If we fail to find a single region large enough to map the object into
> > the aperture, evict something and search. If we still fail to find
> > enough space, return ENOSPC to distinguish the error from a normal
> > memory allocation failure.
> 
> This is pointless since we don't release the file_offset on unbind only on
> free. ENOSPC may still be a good touch though.
> -ickle

Heh, that was the same review I was going to provide.  Were you hitting
troubles here?  If so, maybe we need to make the offset map a bigger
address space.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20091207/e2256b68/attachment.pgp>


More information about the Intel-gfx mailing list