[Intel-gfx] [PATCH] Remove configurable support for disabling XV.

[Keith Packard]

On Sat, 2009-02-28 at 00:54 -0800, Eric Anholt wrote:
> google shows one instance of this being used a year and a half ago.

A good plan. Why is I830_XV still a compile-time option though?

>  #ifdef I830_XV
> @@ -3078,7 +3073,7 @@ I830ScreenInit(int scrnIndex, ScreenPtr pScreen, int argc, char **argv)
>       * Set this so that the overlay allocation is factored in when
>       * appropriate.
>       */
> -    pI830->XvEnabled = !pI830->XvDisabled;
> +    pI830->XvEnabled = TRUE;
>  #endif
>  
> 
> @@ -3107,13 +3102,11 @@ I830ScreenInit(int scrnIndex, ScreenPtr pScreen, int argc, char **argv)
>        return FALSE;
>  
>  #ifdef I830_XV
> -   pI830->XvEnabled = !pI830->XvDisabled;
> -   if (pI830->XvEnabled) {
> -      if (pI830->accel == ACCEL_NONE) {
> -	 xf86DrvMsg(pScrn->scrnIndex, X_PROBED, "Xv is disabled because it "
> -		    "needs 2D acceleration.\n");
> -	 pI830->XvEnabled = FALSE;
> -      }
> +   pI830->XvEnabled = TRUE;
> +   if (pI830->accel == ACCEL_NONE) {
> +      xf86DrvMsg(pScrn->scrnIndex, X_PROBED, "Xv is disabled because it "
> +		 "needs 2D acceleration.\n");
> +      pI830->XvEnabled = FALSE;
>     }
>  #else
>     pI830->XvEnabled = FALSE;
> @@ -3128,16 +3121,6 @@ I830ScreenInit(int scrnIndex, ScreenPtr pScreen, int argc, char **argv)

pI830->XvEnabled is getting set to TRUE twice here; surely that's
unnecessary?

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20090228/89cd57d5/attachment.sig>