[Intel-gfx] [PATCH] Add i915 register dumping debugfs file
bgamari.foss at gmail.com
Thu Jun 18 05:14:48 CEST 2009
On Wed, Jun 17, 2009 at 02:38:41PM -0700, Eric Anholt wrote:
> On Wed, 2009-06-10 at 18:14 -0400, Ben Gamari wrote:
> Do we really need to make a separate file for non-GEM, given that
> non-GEM shouldn't exist any more? If anything, I'd rather that
> i915_gem_debugfs.c just got moved to i915_debugfs.c.
Yeah, this is a good point that I hadn't thought of. I agree that two
files seems a bit excessive. Perhaps we could keep this patch as is and
then move i915_gem_debugfs.c into this file in a later patch?
> Anyway, if this was the patch we went with, lacks licensing in the new
> file, which is inconsistent with the rest of the codebase.
I'll do the requisite cutting and pasting right now. I always forget
about these things. Thanks for the comments,
More information about the Intel-gfx