[Intel-gfx] [PATCH] drm/i915: add FIFO watermark support

Keith Packard keithp at keithp.com
Wed Jun 24 01:17:30 CEST 2009


On Tue, 2009-06-23 at 15:35 -0700, Jesse Barnes wrote:

> +	switch (tmp & 0x7) {
> +	case 1:
> +		dev_priv->fsb_freq = 533; /* 133*4 */
> +		break;
> +	case 2:
> +		dev_priv->fsb_freq = 800; /* 200*4 */
> +		break;
> +	case 3:
> +		dev_priv->fsb_freq =  667; /* 167*4 */
> +		break;
> +	case 5:
> +		dev_priv->fsb_freq = 400; /* 100*4 */
> +		break;
> +	}

Please use the defines in the header file instead of constants.

> +
> +	switch ((tmp >> 4) & 0x7) {
> +	case 1:
> +		dev_priv->mem_freq = 533;
> +		break;
> +	case 2:
> +		dev_priv->mem_freq = 667;
> +		break;
> +	case 3:
> +		dev_priv->mem_freq = 800;
> +		break;
> +	}
> +}

Please add suitable defines to the header file and use them instead of
constants.

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20090623/aef2547e/attachment.pgp>


More information about the Intel-gfx mailing list