[Intel-gfx] [PATCH] drm/i915: Check for dev->primary->master before dereference.
eric at anholt.net
Fri Mar 20 20:41:18 CET 2009
On Fri, 2009-03-06 at 23:27 +0000, Chris Wilson wrote:
> I've hit the occasional oops inside i915_wait_ring() with an indication of
> a NULL derefence of dev->primary->master. Adding a NULL check is
> consistent with the other potential users of dev->primary->master.
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
Given how many bugs we've had with these perf_boxes settings, we may
want to just nuke them at some point. It looks like the userland debug
code that used the flags went away in 2007.
Does anyone care for them continuing to exist? Do we have any
obligation to keep them? I think for any future performance debug like
these did, we'd just expose values in debugfs (it keeps the debug code
from interfering with app behavior, anyway).
eric at anholt.net eric.anholt at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 197 bytes
Desc: This is a digitally signed message part
More information about the Intel-gfx