[Intel-gfx] [PATCH] drm/i915: Use LVDS config in Driver feature BDB for integrated LVDS check

[Wang, Zhenyu Z]

On 2009.03.24 05:02:53 +0800, Chris Wilson wrote:
> On Mon, 2009-03-02 at 10:47 +0800, Wang, Zhenyu Z wrote:
> > On 2009.02.27 11:09:02 +0800, Wang, Zhenyu Z wrote:
> > > On 2009.02.25 09:58:11 +0800, Wang, Zhenyu Z wrote:
> > > > The LVDS config bits in VBT driver feature block is used by vendor
> > > > to identify the board implement of integrated LVDS/eDP or SDVO LVDS.
> > > > And video bios also uses these bits for LVDS enabling or not. So this
> > > > should be reliable for LVDS detect, and may eliminate quirks.
> > > > 
> > > 
> > > Eric, hold on commit this one. We have met LVDS failure with current ddx driver,
> > > like bug 20339, although a bios upgrade fixed the problem. We might check BDB
> > > version to verfiy driver feature block definition, and only use the block info
> > > when satisfied.
> 
> Testing drm-intel-next on my eee/i915, the LVDS was no longer being
> detected. The issue appears to be "[drm] failed to find VBIOS tables"
> which means that dev_priv->int_lvds_support is left as zero and
> intel_lvds_init() is skipped.

yeah, that might be better to be changed to no_int_lvds_support. 
I'm not sure about why your VBIOS init failed, but that commit should be
reverted for now, as it seems to break on some machines, although might save
quirks for others. I'll rework it when we got solid info on this.

-- 
Open Source Technology Center, Intel ltd.

$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20090324/433f5e90/attachment.sig>