[Intel-gfx] compiz swapbuffers patch

Jesse Barnes jbarnes at virtuousgeek.org
Fri May 8 18:41:45 CEST 2009


On Fri, 08 May 2009 10:27:49 +0100
Barry Scott <barry.scott at onelan.co.uk> wrote:

> Jesse Barnes wrote:
> 
> Why are you comparing booleans to TRUE and worse then negating the
> result?
> 
> if( !noWait )
> 
> Is clearer.
> 
> -			waitForVideoSync (s);
> +			if (!(noWait == TRUE))
> +			    waitForVideoSync (s);

Yeah I've been looking at too much X code.  In some places the style is
like if (foo == NULL) { ... handle failure ...}.

I really prefer the shorter checks though; not sure why I jumped
through hoops here.

-- 
--
Jesse Barnes, Intel Open Source Technology Center



More information about the Intel-gfx mailing list