[Intel-gfx] [PATCH] [resend] bug in connector connection status for G33

[Zhenyu Wang]

On 2009.11.10 11:50:04 -0400, Emmanuel wrote:
> Hi all,
> I had trouble booting with my G33 MB with KMS on and intel driver.
> The reason is that even with my LCD TV attached to the VGA output (there
> is only this one) it would say that there was nothing attached to VGA
> (looking in the sysfs connector status for example).
> The attached patch is a temporary work-around: it prevent the intel
> driver to use detect_hotplug for G33, it uses detect_ddc which works
> great. I filed a bug report for Ubuntu here:
> https://bugs.launchpad.net/ubuntu/+source/xserver-xorg-video-intel/+bug/467841
> where you have all the needed files.
> I can test some patches to get the hotplug method to work if needed.

I think I was doing a patch for VGA detect failure against a broken
projector here, but later I just found I don't need it, maybe someone
fixed the projector. ;)

Could you try if this one helps?

diff --git a/drivers/gpu/drm/i915/intel_crt.c b/drivers/gpu/drm/i915/intel_crt.c
index 212e227..e505144 100644
--- a/drivers/gpu/drm/i915/intel_crt.c
+++ b/drivers/gpu/drm/i915/intel_crt.c
@@ -262,8 +262,8 @@ static bool intel_crt_detect_hotplug(struct drm_connector *connector)
 		} while (time_after(timeout, jiffies));
 	}
 
-	if ((I915_READ(PORT_HOTPLUG_STAT) & CRT_HOTPLUG_MONITOR_MASK) ==
-	    CRT_HOTPLUG_MONITOR_COLOR)
+	if ((I915_READ(PORT_HOTPLUG_STAT) & CRT_HOTPLUG_MONITOR_MASK) !=
+	    CRT_HOTPLUG_MONITOR_NONE)
 		return true;
 
 	return false;

-- 
Open Source Technology Center, Intel ltd.

$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20091111/2850288e/attachment.sig>