[Intel-gfx] [PATCH 2/3] Xv overlay: set default color-key to black
daniel at ffwll.ch
Sat Nov 7 00:15:10 PST 2009
On Thu, Nov 05, 2009 at 03:01:20PM -0800, Eric Anholt wrote:
> On Mon, 2009-10-26 at 14:15 +0100, Daniel Vetter wrote:
> > This way we avoid the dreaded blue. Furthermore most video players
> > use black as background, so no one can notice the color-key painting.
> > Leaking of the overlay outside the window is only possible when moving,
> > because the kernel should place it pixel-accurate.
> So, if I drag a window containing black over my XV overlay window, the
> movie will show through, right?
> I think some video players actually painted over the color key for
> interface, as well. This would likely break that, given that black's a
> common color.
Yes, you're right. Of course, we can slightly change it to 010101 like we
do with the blue, but that's gonna look ugly with anti-aliased black
fonts, sooner or later. Let's just drop this one and remind people (like
me) with that ugly blue that they should somewhen upgrade their hw to
something more decent.
Mail: daniel at ffwll.ch
Mobile: +41 (0)79 365 57 48
More information about the Intel-gfx