[Intel-gfx] [PATCH 1/3] agp/intel: remove restore in resume

Zhenyu Wang zhenyuw at linux.intel.com
Fri Sep 11 03:49:54 CEST 2009


On 2009.09.10 18:22:57 -0700, Andrew Morton wrote:
> 
> We still don't have a changelog for this patch which explains to the
> -stable maintainers (and those who follow -stable commits):
> 
> a) what bug this patch fixes and
> 
> b) why they should merge it - this should be ovbious if a) is provided.
> 
> this isn't pointless paperwork - it matters to those who maintain and
> use the -stable tree.  Vague references to traffic on the linux-pm list
> aren't at all useful.

Yes, thanks. I'll try to make it clear the bug it fixes. 

> >From my reading of the above, it appears that Alan was experiencing
> <secretbug> and this patch was tested and fixed it, yes?

secretbug? Alan found resume hang on his 845G machine during his pm test,
and root cause that to extra pci config restore in agp/intel resume function,
which was having a fix to workaround resume order problem for host bridge and
gfx device for pci restore. But now this is handled by early pci resume already,
but the extra restore in resume caused machine hang. So remove them fixed
Alan's hang issue.

Sorry, I might misread on something, "early version merged" seems nonsense.
I'll try to send them again.

-- 
Open Source Technology Center, Intel ltd.

$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20090911/06f651ca/attachment.pgp>


More information about the Intel-gfx mailing list