[Intel-gfx] [PATCH] drm/i915: Don't enable pipe/plane/VCO early (wait for DPMS on).

Carl Worth cworth at cworth.org
Fri Apr 9 08:31:57 CEST 2010


The existing code handling the DPMS ON event is much more careful to
ensure that these registers are enabled according to strict sequencing
requirements. Enabling these early in mode_set simply defeats that.

It's likely that this fixes problems with LVDS coming up blank about
50% of the time on Ironlake, (noted on lenovo x201s).

Signed-off-by: Carl Worth <cworth at cworth.org>
---
 drivers/gpu/drm/i915/intel_display.c |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 0e2c5da..d0f5a65 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -3264,11 +3264,6 @@ static int intel_crtc_mode_set(struct drm_crtc *crtc,
 			pipeconf &= ~PIPEACONF_DOUBLE_WIDE;
 	}
 
-	dspcntr |= DISPLAY_PLANE_ENABLE;
-	pipeconf |= PIPEACONF_ENABLE;
-	dpll |= DPLL_VCO_ENABLE;
-
-
 	/* Disable the panel fitter if it was on our pipe */
 	if (!HAS_PCH_SPLIT(dev) && intel_panel_fitter_pipe(dev) == pipe)
 		I915_WRITE(PFIT_CONTROL, 0);
-- 
1.7.0




More information about the Intel-gfx mailing list