[Intel-gfx] [Patch 3/5] multiple ring buffer support, add BSD ring buffer support
nanhai.zou at intel.com
Tue Apr 6 23:13:00 PDT 2010
>>From: Anholt, Eric
>>Sent: 2010年4月3日 4:34
>>To: Zou, Nanhai; intel-gfx at lists.freedesktop.org
>>Subject: Re: [Intel-gfx] [Patch 3/5] multiple ring buffer support, add BSD ring
>>On Fri, 2 Apr 2010 13:30:43 +0800, "Zou, Nanhai" <nanhai.zou at intel.com> wrote:
>>> This add a new ring buffer support to G45+ system, BSD() ring buffer
>>> BSD (bit-stream-decoder) engine is a separate GPU decode engine to H.264/VC1
>>VLD decoding .
>>A bunch of this code looks to be gratiutously duplicated between ring
>>types -- bsd_ring_add_request() reads just like
>>render_ring_add_request. Even the bsd_init_ring looks like
>>render_init_ring with the register addresses changed. If the register
>>addresses were part of the ring struct we'd have a lot less duplicated
>>logic, I think.
Thanks for reviewing.
I have considered merge the ring init and add_request etc code.
However I'm not sure later generation ring buffers like MFX ring and blit ring
have the same logic.
Anyway I merge the ring buffer init logic to save some lines of code. I have clean up the patches according to your comments and retargeted it to drm-intel-next.
I will send them again.
More information about the Intel-gfx