[Intel-gfx] [PATCH 1/4] drm/i915: don't allow tiling changes on pinned buffers

Daniel Vetter daniel.vetter at ffwll.ch
Thu Apr 22 22:12:49 CEST 2010


Makes no sense and complicates matters for pipelined tiling changes.
So don't allow it and return -EBUSY.

Signed-off-by: Daniel Vetter <daniel.vetter at ffwll.ch>
---
 drivers/gpu/drm/i915/i915_gem_tiling.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_gem_tiling.c b/drivers/gpu/drm/i915/i915_gem_tiling.c
index 449157f..00f264d 100644
--- a/drivers/gpu/drm/i915/i915_gem_tiling.c
+++ b/drivers/gpu/drm/i915/i915_gem_tiling.c
@@ -287,6 +287,9 @@ i915_gem_set_tiling(struct drm_device *dev, void *data,
 		return -EINVAL;
 	}
 
+	if (obj_priv->pin_count)
+		return -EBUSY;
+
 	if (args->tiling_mode == I915_TILING_NONE) {
 		args->swizzle_mode = I915_BIT_6_SWIZZLE_NONE;
 		args->stride = 0;
-- 
1.6.6.1




More information about the Intel-gfx mailing list