[PATCH 1/2] i830: pixman_blt may fail, ensure we pass this result down

Peter Clifton pcjc2 at cam.ac.uk
Thu Apr 22 10:59:49 PDT 2010


Fixes visual corruption noticed in the background of
OpenOffice Impress slides and slide preview seen since
commit 1cc2c2c44ac72460cf1c4e6bdc13c612235809c9

Signed-off-by: Peter Clifton <pcjc2 at cam.ac.uk>
---
 src/i830_uxa.c |   17 ++++++++---------
 1 files changed, 8 insertions(+), 9 deletions(-)

diff --git a/src/i830_uxa.c b/src/i830_uxa.c
index 984069e..4f0c250 100644
--- a/src/i830_uxa.c
+++ b/src/i830_uxa.c
@@ -832,17 +832,16 @@ static Bool i830_uxa_put_image(PixmapPtr pixmap,
 			return FALSE;
 		}
 
-		pixman_blt((uint32_t *)src, priv->bo->virtual,
-			   src_pitch / sizeof(uint32_t),
-			   pixmap->devKind / sizeof(uint32_t),
-			   pixmap->drawable.bitsPerPixel,
-			   pixmap->drawable.bitsPerPixel,
-			   0, 0,
-			   x, y,
-			   w, h);
+		ret = pixman_blt((uint32_t *)src, priv->bo->virtual,
+				 src_pitch / sizeof(uint32_t),
+				 pixmap->devKind / sizeof(uint32_t),
+				 pixmap->drawable.bitsPerPixel,
+				 pixmap->drawable.bitsPerPixel,
+				 0, 0,
+				 x, y,
+				 w, h);
 
 		drm_intel_gem_bo_unmap_gtt(priv->bo);
-		ret = TRUE;
 	}
 
 	return ret;
-- 
1.7.0.4


--=-DUxabE27zjCfVsZmsr2p
Content-Disposition: inline; filename*0=0002-i830-Use-the-i830_pixmap_pitch-helper-function-for-c.pat; filename*1=ch
Content-Type: text/x-patch; name="0002-i830-Use-the-i830_pixmap_pitch-helper-function-for-c.patch"; charset="UTF-8"
Content-Transfer-Encoding: 7bit



More information about the Intel-gfx mailing list