[Intel-gfx] [PATCH] drm/i915: Ensure that while(INREG()) are bounded.
chris at chris-wilson.co.uk
Fri Aug 6 14:39:48 PDT 2010
On Fri, 06 Aug 2010 14:23:37 -0700, Eric Anholt <eric at anholt.net> wrote:
> On Fri, 6 Aug 2010 16:11:54 +0100, Chris Wilson <chris at chris-wilson.co.uk> wrote:
> > Add a new macro, wait_for, to simplify the act of waiting on a register
> > to change state. wait_for() takes three arguments, the condition to
> > inspect on every loop, the maximum amount of time to wait and whether to
> > yield the cpu for a length of time after each check.
> These failures seem DRM_ERROR()-worthy. What do you think? But I do
> like the looks of this patch.
Yes, I made them DRM_ERROR, noticed that surrounding code didn't seem to
treat them as errors and made them debug instead.
The ultimate goal I have in mind here is to return the error code and fail
gracefully. Lofty ideals.
In the meantime, it persistently report:
[drm:ironlake_crtc_dpms] *ERROR* failed to turn off cpu pipe
which is worrying (and indeed the reason why Adam first added the
Chris Wilson, Intel Open Source Technology Centre
More information about the Intel-gfx