[Intel-gfx] [PATCH 26/29] drm/i915: Invert watermarks used for i8xx, i9xx.

Eric Anholt eric at anholt.net
Tue Aug 31 00:39:10 CEST 2010


On Sun, 22 Aug 2010 12:05:45 +0100, Chris Wilson <chris at chris-wilson.co.uk> wrote:
> The calculation seem backwards as they compute the number of entries
> that would be drained during a memory fetch, and but return the opposite
> value.
> 
> This fixes a common flicker [or even completely scrambled display] on
> high resolution outputs (e.g. 1920x1080 with 915GM). However, as we do not
> adjust DSPARB, we are still limited by the FIFO setup by the BIOS which may
> continue to cause underruns with high resolutions on some machines.
> 
> References:
> 
>   Bug 22996 - [945GM] external lcd does not work on high resolution
>   https://bugs.freedesktop.org/show_bug.cgi?id=22996
> 
>   Bug 25284 - [915GM] random flickering when using metacity-compositor
>   https://bugs.freedesktop.org/show_bug.cgi?id=25284
> 
>   Bug 25857 - [945]: Entire screen "jerks" randomly after removing external monitor
>   https://bugs.freedesktop.org/show_bug.cgi?id=25857
> 
>   Bug 27738 - [915] 1920x1200 resolution fails, probable FIFO issue.
>   https://bugs.freedesktop.org/show_bug.cgi?id=27738
> 
>   Bug 28149 - [945GM] KMS regression.
>   https://bugs.freedesktop.org/show_bug.cgi?id=28149
> 
> Also it may address some instances where the monitor fails to sync
> due to underruns.

What's up with all the bug references here?  I hit the first 3 and
didn't see any mention of this patch.  I'd probably prefer to see either
Tested-by or nothing.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20100830/a6f67c22/attachment.pgp>


More information about the Intel-gfx mailing list