[Intel-gfx] [PATCH 1/2] drm/i915: avoid reading non-existent PLL reg on Ironlake+

Jesse Barnes jbarnes at virtuousgeek.org
Thu Dec 30 21:22:17 CET 2010


On Thu, 30 Dec 2010 19:50:17 +0000
Chris Wilson <chris at chris-wilson.co.uk> wrote:

> On Thu, 30 Dec 2010 09:36:39 -0800, Jesse Barnes <jbarnes at virtuousgeek.org> wrote:
> > These functions need to be reworked for Ironlake and above, but until
> > then at least avoid reading non-existent registers.
> 
> This looks good by itself and provided an opportunity for another tiny
> cleanup... Pushed to -next. Though it does raise the question if we are
> arming the upclock timer even when there is nothing to be done and so
> causing excess wakeups?

Yeah, we shouldn't be doing that.  I thought we had it disabled but I
haven't checked.

-- 
Jesse Barnes, Intel Open Source Technology Center



More information about the Intel-gfx mailing list