[Intel-gfx] [PATCH] drm/i915: Update write_domains on active list after flush.

[Adam Lantos]

Hi Eric,

On Wed, Feb 10, 2010 at 10:34 PM, Eric Anholt <eric at anholt.net> wrote:
> On Sun, 7 Feb 2010 18:39:49 +0100, Adam Lantos <hege at playma.org> wrote:
>> This patch seems to fix the BUG_ON in my case. However, I still have
>> lots of these:
>>
>> [drm:i915_gem_object_pin_and_relocate] *ERROR* Failure to install fence: -28
>> [drm:i915_gem_object_pin_and_relocate] *ERROR* Failure to install fence: -28
>> [drm:i915_gem_do_execbuffer] *ERROR* Failed to pin buffer 5 of 7,
>> total 8519680 bytes: -28
>> [drm:i915_gem_do_execbuffer] *ERROR* 369 objects [7 pinned], 91172864
>> object bytes [11747328 pinned], 11780096/260308992 gtt bytes
>
> This commit ought to fix those:
>
> commit fdcde592c2c48e143251672cf2e82debb07606bd
> Author: Chris Wilson <chris at chris-wilson.co.uk>
> Date:   Tue Feb 9 08:32:54 2010 +0000
>
>    intel: Account for potential pinned buffers hogging fences

I applied  drm/i915: Don't reserve compatibility fence regs in KMS mode
as per Daniel's suggestion, and it's also suppressing those messages.

Do I need this patch, too?

>
> (Having the kernel tell the current value wouldn't help in this case,
> since the current value can change periodically and we don't actually
> want to keep asking the kernel what current is just in case we can have
> one extra fence reg).
>