[Intel-gfx] mesa doesn't work with compiz (i965 + tips of all branches)

[Maxim Levitsky]

On Tue, 2010-06-29 at 20:34 +0300, Maxim Levitsky wrote:
> On Sun, 2010-06-27 at 19:07 +0300, Maxim Levitsky wrote:
> > Hi,
> > 
> > Today I updated the graphical modules from long time ago.
> > 
> > Do you know what causes this:
> > 
> > /usr/bin/compiz.real (core) - Warn: No GLXFBConfig for depth 32
> > /usr/bin/compiz.real (core) - Warn: No GLXFBConfig for depth 32
> > /usr/bin/compiz.real (core) - Warn: No GLXFBConfig for depth 32
> > WARNING: Application calling GLX 1.3 function "glXCreatePixmap" when GLX 1.3 is not supported!  This is an application bug!
> > /usr/bin/compiz.real (core) - Warn: No GLXFBConfig for depth 32
> > /usr/bin/compiz.real (core) - Info: Couldn't bind redirected window 0x4000fb to texture
> > 
> > /usr/bin/compiz.real (core) - Warn: No GLXFBConfig for depth 32
> > /usr/bin/compiz.real (core) - Info: Couldn't bind redirected window 0x3a00016 to texture
> > 
> > /usr/bin/compiz.real (video) - Warn: No 8 bit GLX pixmap format, disabling YV12 image format
> > /usr/bin/compiz.real (core) - Warn: No GLXFBConfig for depth 32
> > /usr/bin/compiz.real (resizeinfo) - Warn: Bind Pixmap to Texture failure
> > /usr/bin/compiz.real (core) - Warn: No GLXFBConfig for depth 32
> > /usr/bin/compiz.real (resizeinfo) - Warn: Bind Pixmap to Texture failure
> > /usr/bin/compiz.real (cube) - Warn: Failed to load slide: /usr/share/gdm/themes/Human/ubuntu.png
> > /usr/bin/compiz.real (core) - Warn: No GLXFBConfig for depth 32
> > /usr/bin/compiz.real (core) - Info: Couldn't bind redirected window 0x4000fb to texture
> > 
> > /usr/bin/compiz.real (core) - Warn: No GLXFBConfig for depth 32
> > /usr/bin/compiz.real (core) - Info: Couldn't bind redirected window 0x3a00016 to texture
> > 
> > 
> > The 'good' output was:
> > 
> > ....
> > Checking for Xgl: not present. 
> > WARNING: Application calling GLX 1.3 function "glXCreatePixmap" when GLX 1.3 is not supported!  This is an application bug!
> > /usr/bin/compiz.real (video) - Warn: No 8 bit GLX pixmap format, disabling YV12 image format
> > /usr/bin/compiz.real (cube) - Warn: Failed to load slide: /usr/share/gdm/themes/Human/ubuntu.png
> > WARNING: Application calling GLX 1.3 function "glXDestroyPixmap" when GLX 1.3 is not supported!  This is an application bug!
> > 
> > 
> > 
> > 
> > As a result of this, most windows are white, and decorations are missing.
> > 
> > 
> > glxinfo output indeed shrunk indeed, so maybe this is result of removal of many glx visuals?
> > 
> > 
> > I attach glxinfo output from bad and good versions of mesa.
> > 
> > You will see that I didn't update the stack for some prolonged time, so bisect would be painful.
> > 
> > 
> > Best regards,
> > 	Maxim Levitsky
> 


Bisected this to

73e24cd5a7a0760726a681dda5b88805ddcf1555 is first bad commit
commit 73e24cd5a7a0760726a681dda5b88805ddcf1555
Author: Ian Romanick <ian.d.romanick at intel.com>
Date:   Mon Feb 8 10:34:52 2010 -0800

    intel: Stop exposing useless 24 depth/0 stencil configs
    
    Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
    Reviewed-by: Kristian Høgsberg <krh at bitplanet.net>

:040000 040000 5ba858b23d6502d9eaa39a8ec612a38ffae50e2c 0060acef28a49d519aed5a21cbde2bc833f840a8 M	src



Reverting this, and removing one assert, fixes compiz

diff --git a/src/mesa/drivers/dri/intel/intel_screen.c b/src/mesa/drivers/dri/intel/intel_screen.c
index 61803cf..0f6d1da 100644
--- a/src/mesa/drivers/dri/intel/intel_screen.c
+++ b/src/mesa/drivers/dri/intel/intel_screen.c
@@ -306,7 +306,7 @@ intelCreateBuffer(__DRIscreen * driScrnPriv,
       }
 
       if (mesaVis->depthBits == 24) {
-        assert(mesaVis->stencilBits == 8);
+        //assert(mesaVis->stencilBits == 8);
         /* combined depth/stencil buffer */
         struct intel_renderbuffer *depthStencilRb
            = intel_create_renderbuffer(MESA_FORMAT_S8_Z24);


Best regards,
	Maxim Levitsku