[Intel-gfx] [PATCH 2/4] drm/i915: encoder/connector internal structure rework (v5)
eric at anholt.net
Wed Mar 24 14:03:16 PDT 2010
On Tue, 9 Mar 2010 10:21:57 +0800, Zhenyu Wang <zhenyuw at linux.intel.com> wrote:
> This trys to rework intel driver's internal encoder/connector handling
> code by replacing 'struct intel_output' with specific 'intel_encoder'
> and 'intel_connector' structure, which according to 'drm_encoder' and
> 'drm_connector' respectively.
> The reason to do this is to implement multiple connector types for one
> single SDVO device, so one 'intel_encoder' would be able to driver multiple
> 'intel_connector' objects. We might be able to change internal code in
> SDVO only for this, but I found it would bring lot of confusing and SDVO
> only home-made stuff, and still need to hack driver common code here and
> there. Which lead me to this more intrusive solution, but I hope would lead
> to the most clean one.
> As it removes 'struct intel_output' completely, so patch is quite long
> and mostly for renaming old struct to new encoder/connector structure.
> Test has been made on mobile and desktop 945/965 chips for VGA/HDMI/DP/LVDS/TV,
> SDVO cards for single function DVI and multiple function TVs.
> v2 update:
> - Fix SDVO encoder flag for TV and LVDS
> - Fix DVO subdriver destroy by cleanup in encoder destroy function
> v3 update:
> - Fix HDMI ddc bus destroy
> - Fix flag setting for SDVO TV clock
> - Fix SDVO connector property handling
> v4 update:
> - Rebase onto 'drm-intel-next'
> v5 update:
> - Split SDVO multifunction support code from origin patch
This is not acceptable. The problem in this series is still that step 1
b) also change a bunch of code.
When someone bisects down to this, they will probably just give up.
Doing just the sed is:
11 files changed, 663 insertions(+), 663 deletions(-)
Why should someone have to look through 872 lines of code to find the
bug in the 209 lines of non-automated patch? And why should I have to
review all that sed job even before a bug's been found?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 197 bytes
Desc: not available
More information about the Intel-gfx