[Intel-gfx] [PATCH 2/2] drm/i915: Fix up address spaces in slow_kernel_write()

Daniel Vetter daniel at ffwll.ch
Fri May 28 11:28:50 CEST 2010


On Thu, May 27, 2010 at 02:15:35PM +0100, Chris Wilson wrote:
> Since we now get_user_pages() outside of the mutex prior to performing
> the copy, we kmap() the page inside the copy routine and so need to
> perform an ordinary memcpy() and not copy_from_user().

Patches look sane and will definitely help in (someday) fixing up the racy
pwrite/pread locking. So for both patches:

Reviewed-by: Daniel Vetter <daniel.vetter at ffwll.ch>
-- 
Daniel Vetter
Mail: daniel at ffwll.ch
Mobile: +41 (0)79 365 57 48



More information about the Intel-gfx mailing list