[Intel-gfx] [PATCH] drm/i915: dont use i915_driver_unload() to cleanup failed vblank init

Chris Wilson chris at chris-wilson.co.uk
Wed Nov 17 12:19:13 CET 2010


On Wed, 17 Nov 2010 14:24:53 +0800, Jeremy Kerr <jeremy.kerr at canonical.com> wrote:
> Currently, i915_driver_load calls i915_driver_unload if drm_vblank_init
> fails. However, we have not yet fully initialised drm_i915_private (eg.
> ->hangcheck_timer), so we're calling unload from an inconsistent state.
> 
> This change uses the existing error path to do the cleanup instead, as
> is used before and after the drm_vblank_init() call.

Already done for -next, thanks anyway.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre



More information about the Intel-gfx mailing list