[Intel-gfx] [PATCH] drm/i915: avoid struct mutex output_poll mutex lock loop on unload

Chris Wilson chris at chris-wilson.co.uk
Mon Oct 4 10:49:28 CEST 2010


On Sun,  3 Oct 2010 19:36:26 -0700, Keith Packard <keithp at keithp.com> wrote:
> Cancel the output polling work proc before acquiring the struct mutex
> to avoid acquiring the work proc mutex with the struct mutex
> held. This avoids inverting the lock order seen when the work proc
> runs.

I thought this was part of Daniel's reordering to avoid race conditions
between interrupts and module unload. Fortunately not. The lack of locking
during hotplug is worrisome should we ever do dynamic connectors.

Applied to -next. Now you also said that we have memory corruption after
unload... :(
Thanks,
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre



More information about the Intel-gfx mailing list