[Intel-gfx] [PATCH] i915: Initialize panel timing registers if VBIOS did not.
chris at chris-wilson.co.uk
Fri Oct 8 02:58:40 PDT 2010
On Thu, 7 Oct 2010 17:05:46 -0700, Bryan Freed <bfreed at chromium.org> wrote:
> The time between start of the pixel clock and backlight enable is a basic
> panel timing constraint. If the Panel Power On/Off registers are found
> to be 0, assume we are booting without VBIOS initialization and set these
> registers to something reasonable.
That looks cleaner. Obviously my only concern is what happens if we ever
see a second device that posts without setting up the registers. We may as
well compile in the VBT for every single manufactured device... Or we
could add a ROM table the manufacturers must include that provides the
necessary register values for their hardware. There must be some
replacement for the BIOS, a device description table at least?
Does any one have a strong "this will damage my hardware" objection? Are
the values safe enough for *any* device?
Chris Wilson, Intel Open Source Technology Centre
More information about the Intel-gfx