[Intel-gfx] [PATCH] i915: enable AVI infoframe for intel_hdmi.c [v4]
david at hardeman.nu
Thu Oct 21 15:08:34 PDT 2010
On Thu, Oct 21, 2010 at 10:36:33AM +0100, Chris Wilson wrote:
> On Wed, 20 Oct 2010 21:45:41 +0200, David Härdeman <david at hardeman.nu> wrote:
> > On Fri, Sep 24, 2010 at 09:44:32PM +0200, David Härdeman wrote:
> > > Two questions still remain:
> > >
> > > I'm assuming that the sdvo hardware also stores a header ECC byte in
> > > the MSB of the first dword - is this correct?
> > >
> > > Does the SDVOB and SDVOC handling in intel_hdmi_set_avi_infoframe()
> > > look correct?
> > Ping...
> Sorry David, I thought I had replied but it never made it to the list.
> I was half waiting if someone would find the answer to your questions. I
> am not certain about the reg -> port conversion either, but if it works
> for you, that is a major step forward.
> More importantly, the patch is missing your signed-off-by, which states
> that the work is yours (or at least you vouchsafe for the originality of
> the work) and you are free to contribute this work to upstream.
I intentionally left out the SOB line because I wanted to have my
questions answered first. Assuming that I (random guy without access to
sdvo hw docs) would understand the sdvo avi infoframe programming better
than the original author of the code (presumably someone at Intel with
access to said docs) seemed like an unsafe assumption. On the other
hand, if sdvo breaks, I guess someone will speak up loudly :)
> Just reply adding your 'Signed-off-by' and I'll push the patch to -next.
Signed-off-by: David Härdeman <david at hardeman.nu>
More information about the Intel-gfx