[Intel-gfx] [RFC PATCH 0/2] i915 brightness control
kamal at canonical.com
Fri Sep 24 12:12:55 PDT 2010
On Mon, 2010-09-13 at 18:48 +0100, Matthew Garrett wrote:
> I've looked into this issue more closely and think I've worked out the
> underlying problem. The system in question appears to have two GPUs and
> exposes two ACPI backlight devices. Both of these are associated with
> existing PCI devices, so we don't ignore either of them because of that.
> Further, one of them (the AMD one) implements the spec properly and
> should work. We don't seem to perform a more fine-grained check to
> identify whether every ACPI backlight has all the required methods, and
> so as a result we provide both the working one and the non-working one.
> Having thought about this some more, I don't think this is the right
> approach. We should be ensuring that every backlight ahs all the
> required methods and then dropping the one that doesn't. This should be
> replaced with a native i915 backlight, and I sent patches to do that
> last week.
I agree. Your proposed design is good, and I have successfully tested
your proposed patches (after minor porting changes to Ubuntu
Maverick's 2.6.35). Thanks very much Matthew!
FYI, I have published an experimental Ubuntu Maverick PPA kernel
which includes your patches, plus my dell_laptop tweaks to inhibit the
broken dell_backlight by a module param or dmi blacklist table (in lieu
of a yet to be implemented more fine-grained check).
-Kamal Mostafa <kamal at canonical.com>
 2010-09-08 [Intel-gfx] [PATCH] i915: Add native backlight control
2010-09-08 [Intel-gfx] [PATCH] Backlight: Add backlight type
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 836 bytes
Desc: This is a digitally signed message part
More information about the Intel-gfx