[Intel-gfx] [PATCH 2/3] drm/i915: split irq handling into per-chipset functions

[Chris Wilson]

On Thu, 7 Apr 2011 15:04:14 -0700, Jesse Barnes <jbarnes at virtuousgeek.org> wrote:
> On Thu, 07 Apr 2011 22:50:42 +0100
> Chris Wilson <chris at chris-wilson.co.uk> wrote:
> > One thing we need to be careful is to move the common code into small
> > helper routines to avoid unnecessarily duplicating it.
> 
> But not before we're sure about the duplication!  Obviously things like
> the workqueue init at IRQ install time could be shared,

Actually that workqueue init is in the wrong place entirely, but that
was the sort of generic code I was looking at. ;-)

> but I don't
> like the idea of sharing hardware code unless it's absolutely
> identical, given our history.

Agreed, I think the model you've proposed of doing bring-up on a separate
copy of the code and then gradually merge back the duplicate portions
carries the least risk. Also looking at our history, we carry a lot of
bugs that we only notice when looking at the next chipset iteration...
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre