[Intel-gfx] [PATCH] drm/i915: Check that the plane points to the pipes framebuffer before enabling

Chris Wilson chris at chris-wilson.co.uk
Tue Apr 19 07:55:57 CEST 2011


On Mon, 18 Apr 2011 08:54:44 -0700, Jesse Barnes <jbarnes at virtuousgeek.org> wrote:
> I like it (though now the comment talks about DSPADDR and leaves
> DSPSURF out in the cold).

D'oh. That'll teach me to try and write a comment to explain a function
first!

> Sounds like our dpms code may be causing trouble for this x11perf run
> perhaps?  What else would cause us to change base addrs during a bench
> run like that?

Right. The early observation is that we don't assign a framebuffer to
the CRTC borrowed for VGA/TV load detection. And I can postulate that we
contrived to access a PTE during a hotplug poll whilst rewriting the GTT
(or something similar to the object following the ringbuffer).

I think we can just attach the fbcon for the purposes of load detection.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre



More information about the Intel-gfx mailing list