[Intel-gfx] [PATCH] drm/i915: Combine pinning with setting to the display plane
chris at chris-wilson.co.uk
Sat Apr 16 04:00:21 PDT 2011
On Sat, 16 Apr 2011 12:52:35 +0200, Daniel Vetter <daniel at ffwll.ch> wrote:
> One small comment-nitpick below.
> > diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
> > index 7271956..c73eeaf 100644
> > --- a/drivers/gpu/drm/i915/i915_gem.c
> > +++ b/drivers/gpu/drm/i915/i915_gem.c
> > @@ -3095,40 +3095,55 @@ int i915_gem_object_set_cache_level(struct drm_i915_gem_object *obj,
> > }
> > /*
> > - * Prepare buffer for display plane. Use uninterruptible for possible flush
> > - * wait, as in modesetting process we're not supposed to be interrupted.
> > + * Prepare buffer for display plane (scanout, cursors, etc).
> > + * Expects to be called from an uninterruptible phase (modesetting) and allows
> Shouldn't that be "Can be called from uninterruptible ..."
Yes, I misphrased. I was thinking along the lines that it should be able
to cope with uninterruptible phases but not that it was mandatory.
Chris Wilson, Intel Open Source Technology Centre
More information about the Intel-gfx