[Intel-gfx] [PATCH] drm/i915: fix intel_crtc_get_clock pipe reads after "cleanup"

Jesse Barnes jbarnes at virtuousgeek.org
Fri Apr 22 23:27:44 CEST 2011


On Fri, 22 Apr 2011 22:22:28 +0100
Chris Wilson <chris at chris-wilson.co.uk> wrote:

> Despite the fixes in 548f245ba6a31 (drm/i915: fix per-pipe reads after
> "cleanup"), we missed one neighbouring read that was mistakenly replaced
> with the reg value in 9db4a9c (drm/i915: cleanup per-pipe reg usage).
> This was preventing us from correctly determining the mode the BIOS left
> the panel in for machines that neither have an OpRegion nor access to
> the VBT, (e.g. the EeePC 700).

Hooray for reg offset vs value confusion.  It be clearer to separate
the two some more in this case...

-- 
Jesse Barnes, Intel Open Source Technology Center



More information about the Intel-gfx mailing list