[Intel-gfx] [PATCH] drm/i915: reject GTT domain in relocations

[Chris Wilson]

On Fri,  2 Dec 2011 20:43:21 +0100, Daniel Vetter <daniel.vetter at ffwll.ch> wrote:
> This confuses our domain tracking and can (for gtt write domains) lead
> to a subsequent oops.
> 
> Tested by tests/gem_exec_bad_domains from i-g-t.
> 
> Signed-Off-by: Daniel Vetter <daniel.vetter at ffwll.ch>

If it was in deliberate use by userspace we would have been oopsing,
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>

In a similar vein is to add a
 BUG_ON(obj->base.write_domain & ~I915_GEM_GPU_DOMAINS)
to move_to_active(). With this loop-hole closed, adding an invalid write
buffer to the active list should only be possible through a kernel
programming error (and helps remind us about what the limits upon the
active list are).
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre