[Intel-gfx] [PATCH] drm/i915: Set two chicken bits implicated in missed IRQs on Ivybridge.

Eric Anholt eric at anholt.net
Thu Dec 22 18:39:12 CET 2011


On Wed, 21 Dec 2011 13:26:28 -0800, Ben Widawsky <ben at bwidawsk.net> wrote:
> On 12/21/2011 10:31 AM, Eric Anholt wrote:
> > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> > index 8a61b81..1fe0c67 100644
> > --- a/drivers/gpu/drm/i915/intel_display.c
> > +++ b/drivers/gpu/drm/i915/intel_display.c
> > @@ -8252,6 +8252,10 @@ static void ivybridge_init_clock_gating(struct drm_device *dev)
> >  
> >  	I915_WRITE(ILK_DSPCLK_GATE, IVB_VRHUNIT_CLK_GATE);
> >  
> > +	I915_WRITE(IVB_CHICKEN3,
> > +		   CHICKEN3_DGMG_REQ_OUT_FIX_DISABLE |
> > +		   CHICKEN3_DGMG_DONE_FIX_DISABLE);
> > +
> >  	for_each_pipe(pipe) {
> >  		I915_WRITE(DSPCNTR(pipe),
> >  			   I915_READ(DSPCNTR(pipe)) |
> 
> Fwiw, CHICKEN3_DGMG_DONE_FIX_DISABLE also applies to SNB, but we're
> waiting on feedback if we should set it. It may be better to set both
> platforms at once (ie. hold off on this patch)?

If it's different code in a different place for a different platform, it
should definitely be a different patch.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20111222/c3f74780/attachment.sig>


More information about the Intel-gfx mailing list