[Intel-gfx] [PATCH] uxa/glamor: Prefer to create a pure glamor pixmap.
chris at chris-wilson.co.uk
Fri Dec 23 05:11:54 PST 2011
On Fri, 23 Dec 2011 19:59:22 +0800, zhigang.gong at linux.intel.com wrote:
> From: Zhigang Gong <zhigang.gong at linux.intel.com>
> Prefer to create a pure glamor pixmap rather than a BO and then
> create a texture from that BO in glamor. As this will avoid some
> glFlush requirements, it can get about 20-30% performance gain.
> When glamor is enabled, route the uxa_create_gc to glamor_create_gc.
> This commit also removed the glFlush at the intel_glamor_finish_access.
> When glamor is enabled, a pixmap will not be accessed by the UXA's
> accelerated function. Only un-accelerated funtion may access those
> pixmap, and before each un-accelerated rendering, it calls
> uxa_prepare_access which will do glFlush there.
> Removed deprecated function: intel_glamor_create_screen_image
There are at least four functional changes here, each of which look like
they could have unexpected side-effects. Can you break this patch down
into create using glamor by default; create glamor gc; remove extraneous
flush; remove dead code.
Chris Wilson, Intel Open Source Technology Centre
More information about the Intel-gfx