[Intel-gfx] [PATCH 2/2] dri: Add support for DRI2BufferStencil and DRI2BufferHiz
chris at chris-wilson.co.uk
Sun Jun 5 02:48:29 PDT 2011
On Sat, 4 Jun 2011 17:06:31 -0700, Chad Versace <chad at chad-versace.us> wrote:
> Before this commit, if a client were to request a stencil or hiz buffer, then
> I830DRI2CreateBuffer() allocated and returned an X-tiled buffer by
> accident. (DRI2BufferStencil and DRI2BufferHiz were unintentionally caught
> by the default case of a switch statement.)
> Now, I830DRI2CreateBuffer() correctly returns a Y-tiled buffer and handles
> the stencil buffer as a special case due its quirky pitch requirements.
Yeah, this really highlights how broken the ddx is by conflating Pixmaps
and RenderBuffer attachments.
However as a short-term feature addition, it looks fine.
Chris Wilson, Intel Open Source Technology Centre
More information about the Intel-gfx