[Intel-gfx] [PATCH] drm/i915: use i915_enable_rc6 on SNB too

[Jesse Barnes]

On Wed, 30 Mar 2011 14:32:51 -0700
Ben Widawsky <ben at bwidawsk.net> wrote:

> On Wed, Mar 30, 2011 at 02:08:56PM -0700, Jesse Barnes wrote:
> > For debug & testing.
> > 
> > Signed-off-by: Jesse Barnes <jbarnes at virtuousgeek.org>
> > ---
> 
> >  	I915_WRITE(GEN6_RC_CONTROL,
> > -		   GEN6_RC_CTL_RC6p_ENABLE |
> > -		   GEN6_RC_CTL_RC6_ENABLE |
> > +		   rc6_mask |
> >  		   GEN6_RC_CTL_EI_MODE(1) |
> >  		   GEN6_RC_CTL_HW_ENABLE);
> > 
> 
> Do you also need to set GEN6_RC_CTL_RC7_ENABLE if !i915_enable_rc6? I
> don't really know how the hardware works, but I had a similar untested
> patch except I added that bit in the rc6 disable case.

That seems to control LLC way sharing between GT and the CPU; not sure
if switching to an RC7 message is correct or not if RC6 is disabled
though.

-- 
Jesse Barnes, Intel Open Source Technology Center