[Intel-gfx] [PATCH 13/19] drm/i915: untested DP support for Ivy Bridge

[Jesse Barnes]

On Sun, 01 May 2011 17:26:11 +0100
Chris Wilson <chris at chris-wilson.co.uk> wrote:

> On Thu, 28 Apr 2011 15:12:59 -0700, Jesse Barnes <jbarnes at virtuousgeek.org> wrote:
> > Treat it like Sandy Bridge in a few places.
> > 
> > Signed-off-by: Jesse Barnes <jbarnes at virtuousgeek.org>
> > ---
> >  drivers/gpu/drm/i915/intel_dp.c |    6 +++---
> >  1 files changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> > index 0daefca..1d0eccd 100644
> > --- a/drivers/gpu/drm/i915/intel_dp.c
> > +++ b/drivers/gpu/drm/i915/intel_dp.c
> > @@ -312,7 +312,7 @@ intel_dp_aux_ch(struct intel_dp *intel_dp,
> >  	else
> >  		aux_clock_divider = intel_hrawclk(dev) / 2;
> >  
> > -	if (IS_GEN6(dev))
> > +	if (IS_GEN6(dev) || IS_GEN7(dev))
> 
> Shouldn't these be IS_SANDYBRIDGE(dev) || IS_IVYBRIDGE(dev) following the
> convention that info->gen is reserved for the render engine.
> 
> Perhaps if you do the s/IS_GEN6/IS_SNADYBRIDGE/ fixes first it will become
> much clearer? :)

Yeah, sorry I violated my own rule, will fix (this one can be delayed
until I can test it anyway).

-- 
Jesse Barnes, Intel Open Source Technology Center