[Intel-gfx] [PATCH] drm/i915: clarify IS_GEN vs IS_<product> usage

Chris Wilson chris at chris-wilson.co.uk
Mon May 9 21:09:22 CEST 2011


On Mon, 9 May 2011 11:42:13 -0700, Jesse Barnes <jbarnes at virtuousgeek.org> wrote:
> On Thu, 05 May 2011 23:57:56 +0100
> Chris Wilson <chris at chris-wilson.co.uk> wrote:
> > Whilst you are in the vicinity, does it make sense to rename info->gen to
> > info->render (or info->render_gen)?
> 
> Sure.

Ok, that really does reveal in how many locations we have conflated the
display generation and the render generation. I think the next step would
be a display generation enum. The third generation counter would be the
BIOS/chipset series. And then we have those promiscuous registers used
everywhere!

Reading through it, I think the render_gen patch just highlights the
obvious confusion and so we shouldn't apply it until we have some remedial
patches.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre



More information about the Intel-gfx mailing list