[Intel-gfx] [PATCH 0/2] intel-gen4asm: modernization

Eric Anholt eric at anholt.net
Mon May 9 22:45:45 CEST 2011


On Fri,  6 May 2011 11:34:25 -0700, Ben Widawsky <ben at bwidawsk.net> wrote:
> 
> I attempted to merge the assembler into the modern age. Ideally we should be
> able to push the changes back into mesa since it appears Haihao added some
> relevant structs.
> 
> I've only done very limited testing on this for my usecase. Wondering if
> this seems acceptable to push? What is the best way to actually test
> this?
> 
> Most of the changes are copy-paste, but only moderate amount of merging
> occurred in brw_structs.h, and brw_defines.h

You should probably test that generation of existing code (2d driver,
probably vaapi?) hasn't changed.  Also that you've run the newly-changed
generated code somehow.

There's a testsuite for round-trip asm-to-disasm, but it looks like
that's already pre-broken by some past change.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20110509/196c1b4a/attachment.sig>


More information about the Intel-gfx mailing list