[Intel-gfx] [PATCH 08/17] drm/i915: Move the tracking of dpms_mode down into crtc enable/disable
chris at chris-wilson.co.uk
Wed May 4 14:59:38 PDT 2011
On Wed, 04 May 2011 14:20:27 -0700, Keith Packard <keithp at keithp.com> wrote:
> On Wed, 04 May 2011 20:40:37 +0100, Chris Wilson <chris at chris-wilson.co.uk> wrote:
> > We can remove dpms_mode in favour of solely using active.
> That sounds like a good plan.
> And what about the intel_dp->dpms_mode value? Should it be switched to a
> simple 'active' boolean as well? Or is the existing crtc->active value
The sticky point is the usage within release-load-detect-pipe where we
restore the "dpms-mode". As it stands today, we treat dpms-mode as if it
were just a boolean value (ignoring the unknown value). But we should keep
the code generic, if it doesn't incur any additional burden, so I'm
favouring a multi-valued active or actual-dpms-mode.
Chris Wilson, Intel Open Source Technology Centre
More information about the Intel-gfx