[Intel-gfx] [PATCH 06/16] drm/i915: Replace ironlake_compute_wm0 with g4x_compute_wm0

Chris Wilson chris at chris-wilson.co.uk
Fri May 13 11:19:52 CEST 2011


On Thu, 12 May 2011 17:34:49 -0700, Keith Packard <keithp at keithp.com> wrote:
> On Thu, 12 May 2011 22:17:14 +0100, Chris Wilson <chris at chris-wilson.co.uk> wrote:
> > The computation of the first-level watermarks for g4x and gen5+ are
> > based on the same algorithm, so we can refactor those code paths to
> > use a single function.
> 
> g4x_compute_wm0 takes a plane. ironlake_compute_wm0 takes a pipe. The
> change implicitly assumes that pipe == plane on ironlake. Please clarify?

We lucked out. It should have been a plane on Ironlake as well.
Fortunately on ILK+ each pipe is slaved to one (identically numbered)
plane.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre



More information about the Intel-gfx mailing list